Skip to content

Struct slop detector rules #3

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
cuonglm opened this issue Sep 18, 2020 · 2 comments
Closed

Struct slop detector rules #3

cuonglm opened this issue Sep 18, 2020 · 2 comments
Assignees

Comments

@cuonglm
Copy link
Contributor

cuonglm commented Sep 18, 2020

There's an existing tool which does report if the struct is not probably aligned https://github.com/mdempsky/maligned

Things we need to clarify:

  • Is the tool updated?
  • If we can re-use it, is there problem with LICENSE?

I can discuss with Matthew for those things.

@cuonglm cuonglm self-assigned this Sep 18, 2020
@odeke-em
Copy link
Member

odeke-em commented Sep 18, 2020

Would be nice though to show optimal arrangement suggestions and not just report misalignment.

The license is owned by the Go Authors https://github.com/mdempsky/maligned/blob/6e39bd26a8c8b58c5a22129593044655a9e25959/maligned.go#L1-L3 or at least that’s what Matthew dedicated it for.

@cuonglm
Copy link
Contributor Author

cuonglm commented Sep 18, 2020

Would be nice though to show optimal arrangement suggestions and not just report misalignment.

Ah right, good point.

I think that can be easily done once we detect the misalignment.

cuonglm pushed a commit that referenced this issue Sep 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants