-
Notifications
You must be signed in to change notification settings - Fork 27
Add more test cases #6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@odeke-em I think we can remove the TODO about the "_ [0]func()", because if it's already the first field of struct, it will always be there.
|
Let’s ensure we have a concrete test for this and can then close it.
…On Mon, Sep 21, 2020 at 9:54 PM Cuong Manh Le ***@***.***> wrote:
@odeke-em <https://github.com/odeke-em> I think we can remove the TODO
about the "_ [0]func()", because if it's already the first field of struct,
it will always be there.
_ [0]func has size 0 and align of 8, so it always goes before others when
we sort fields.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFL3V73LUCFXDGEDVVK4FTSHAUWRANCNFSM4RUZPNUA>
.
|
cuonglm
pushed a commit
that referenced
this issue
Sep 22, 2020
cuonglm
added a commit
that referenced
this issue
Sep 22, 2020
Fixes #6 Co-authored-by: Cuong Manh Le <cuong@orijtech.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
When #5 were merged, we should add more test cases.
What can be edge case for this?
The text was updated successfully, but these errors were encountered: