Skip to content

Add more test cases #6

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
cuonglm opened this issue Sep 21, 2020 · 2 comments · Fixed by #9
Closed

Add more test cases #6

cuonglm opened this issue Sep 21, 2020 · 2 comments · Fixed by #9
Assignees

Comments

@cuonglm
Copy link
Contributor

cuonglm commented Sep 21, 2020

When #5 were merged, we should add more test cases.

What can be edge case for this?

@cuonglm
Copy link
Contributor Author

cuonglm commented Sep 22, 2020

@odeke-em I think we can remove the TODO about the "_ [0]func()", because if it's already the first field of struct, it will always be there.

_ [0]func has size 0 and align of 8, so it always goes before others when we sort fields.

@odeke-em
Copy link
Member

odeke-em commented Sep 22, 2020 via email

cuonglm pushed a commit that referenced this issue Sep 22, 2020
cuonglm added a commit that referenced this issue Sep 22, 2020
Fixes #6

Co-authored-by: Cuong Manh Le <cuong@orijtech.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants