Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Made it possible to override entrypoint #711

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Made it possible to override entrypoint #711

merged 5 commits into from
Nov 4, 2022

Conversation

brurucy
Copy link
Contributor

@brurucy brurucy commented Nov 1, 2022

Quite often you have an image, and you want to change the ENTRYPOINT.

This is a very tiny change, all that I did was to create a new option.

@brurucy
Copy link
Contributor Author

brurucy commented Nov 1, 2022

@orlangure I have tested it locally for side-effects, and it seems to work just fine.

@brurucy brurucy mentioned this pull request Nov 2, 2022
@orlangure
Copy link
Owner

Hi @brurucy and thank you so much for your contribution!

I like the idea, but unfortunately I have a very busy schedule this week, so I will be able to take a closer look, merge the PR and prepare a new release a little bit later. I really hope to do that until the end of this week.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Base: 85.80% // Head: 85.91% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (192c088) compared to base (f6a5b27).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   85.80%   85.91%   +0.11%     
==========================================
  Files          49       49              
  Lines        2310     2315       +5     
==========================================
+ Hits         1982     1989       +7     
+ Misses        170      169       -1     
+ Partials      158      157       -1     
Impacted Files Coverage Δ
docker.go 89.56% <100.00%> (+0.09%) ⬆️
options.go 100.00% <100.00%> (ø)
preset/kafka/preset.go 79.10% <0.00%> (+1.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

gnomock_test.go Outdated Show resolved Hide resolved
@brurucy brurucy requested a review from orlangure November 3, 2022 20:37
Copy link
Owner

@orlangure orlangure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@orlangure orlangure merged commit 520c655 into orlangure:master Nov 4, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants