-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add extra hosts option #755
Conversation
Hi @Haegi and thank you for the contribution! I wasn't aware of this flag, this is really cool! |
Codecov ReportBase: 86.09% // Head: 65.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #755 +/- ##
===========================================
- Coverage 86.09% 65.71% -20.38%
===========================================
Files 49 49
Lines 2315 2319 +4
===========================================
- Hits 1993 1524 -469
- Misses 167 687 +520
+ Partials 155 108 -47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I just added some tests and I also adapted the PR description. |
I'll take a look, I guess something broke in |
Thanks :) |
Hey, I fixed the k3s preset issue in #760, please rebase from |
488e545
to
b26ec39
Compare
Thanks @orlangure! I rebased from master but it seems like the github action is now broken. Is this because of my change and should I have a look at it? |
@Haegi, no this is just a flaky job that I don't have capacity to look into. I will merge and prepare a release this weekend, everything looks great. Thank you! |
Context
At the moment gnomock doesn't support adding extra hosts to the container.
This PR adds a
WithExtraHosts
option, which implements exactly that.If the option is provided, the extra hosts will be added to the container and otherwise it will just receive an empty array and it will do nothing with it.
Notes
I am not sure on a proper test for it.Maybe I could run some busybox and check if the specified host is reachable.Tests: