Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade Kafka Preset to 3.3.1-L0 with ARM 64 Support #982

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

rajatvig
Copy link
Contributor

No description provided.

@rajatvig rajatvig marked this pull request as ready for review August 17, 2023 23:05
@rajatvig
Copy link
Contributor Author

@orlangure Would I be right in assuming that the changes would work? Is there something else I need to change?

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Patch coverage: 84.81% and project coverage change: -0.25% ⚠️

Comparison is base (97f7ed9) 85.87% compared to head (ffda0d0) 85.63%.
Report is 16 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   85.87%   85.63%   -0.25%     
==========================================
  Files          50       55       +5     
  Lines        2350     2561     +211     
==========================================
+ Hits         2018     2193     +175     
- Misses        173      191      +18     
- Partials      159      177      +18     
Files Changed Coverage Δ
preset/kafka/preset.go 77.61% <ø> (ø)
preset/azurite/options_blobstorage.go 70.14% <70.14%> (ø)
preset/vault/preset.go 77.41% <77.41%> (ø)
preset/k3s/preset.go 80.39% <94.11%> (-0.95%) ⬇️
preset/azurite/options.go 100.00% <100.00%> (ø)
preset/azurite/preset.go 100.00% <100.00%> (ø)
preset/cassandra/preset.go 93.10% <100.00%> (ø)
preset/cockroachdb/preset.go 81.53% <100.00%> (ø)
preset/elastic/preset.go 68.70% <100.00%> (+0.24%) ⬆️
preset/k3s/options.go 100.00% <100.00%> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlangure
Copy link
Owner

Hey @rajatvig, thank you for working on this!

Yes, you can assume everything works. The build passes on amd64 instances, and I tested locally on arm64. I'll prepare a new release a little later, thanks!

@rajatvig
Copy link
Contributor Author

@orlangure Could you please consider merging it?

@orlangure orlangure merged commit 88716bd into orlangure:master Aug 24, 2023
@orlangure
Copy link
Owner

Sorry for the delay, I'm planning to prepare a release this weekend. Merged for now 😻

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants