Prevent changing the activity from a component's own thread #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch breaks some tests that call |
meyerj
changed the title
…olchain#141) This patch partially solves issue orocos-toolchain#141. It is not possible to change the activity of a component from within the component's thread because it would have to destroy itself afterwards. RTT::TaskContext::setActivity() logs an error and returns false in this case. The debug log output during thread termination has been moved from the thread destructor to the terminate() method to fix logging during the destruction of RTT::Activity (see also 58cb4bb). Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
This is a workaround for the fact that getActivity()->thread() returns the main thread in some cases and therefore it would not be possible to change the activity from the main thread while it is active, e.g. during unit tests. Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
meyerj
force-pushed
the
fix/check-for-isself-in-setactivity
branch
from
2f70acd to
ddf343f
Compare
doudou
reviewed
Dec 16, 2016
17 tasks
…false Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
meyerj
added a commit
that referenced
this pull request
Apr 16, 2019
…ty into toolchain-2.9.1 Prevent changing the activity from a component's own thread
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch partially solves issue #141. It is not possible to change the activity of a component from within the component's thread because it would have to destroy itself afterwards.
RTT::TaskContext::setActivity()logs an error and returns false in this case.RTT::TaskContext::forceActivity()logs a fatal error.The debug log output during thread termination has been moved from the thread destructor to the
terminate()method to fix logging during the destruction ofRTT::Activity(see also 58cb4bb).