Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow loading of global service plugins via the CORBA interface of each TaskContextProxy #228

Merged

Conversation

meyerj
Copy link
Member

@meyerj meyerj commented Oct 16, 2017

Follow-up of #134, which reverted a patch introduced in #90 for loading global service plugins into an Orocos process from remote peers, which is required for the RTT introspection feature. As far as I know this use case has not yet been solved or worked around differently. @jmachowinski?

From #134 (comment):

The second approach is probably more feasible and similar to the operation you added to the TaskContext interface, but I would only expose the access to PluginLoader::loadPlugin() (or all global services) in TaskContextProxy instances and not for every local TaskContext. And it would not break existing code that already uses the loadPlugin(...) operation on the remote side.

From #134 (comment):

I created a patch that implements the second solution: master...meyerj:fix/load-plugin-for-introspection.
As promised, it is a bit hacky, but would solve the problem. Feel free to create a new PR if the patch also works for you, but it is more a proof-of-concept than something I would really consider to merge. Probably it would be better to implement a PluginLoaderService, add it to the GlobalService and expose this global service to every TaskContextProxy as a fake service "Global" instead of adding only one fake operation.

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
@jmachowinski
Copy link
Member

I'm using your patch, and it is working. Still it is kind of ugly and hacky, but as long as it works its fine for me.

@jmachowinski
Copy link
Member

Ohh, I just read the part about the merge request I was supposed to create, sorry, forgot / overread that part...

@meyerj meyerj merged commit eb17431 into orocos-toolchain:master Oct 26, 2017
@meyerj meyerj deleted the fix/load-plugin-for-introspection branch October 26, 2017 07:17
meyerj added a commit to meyerj/rtt that referenced this pull request Oct 26, 2017
…or-introspection into rdt-toolchain-2.9-cherry-pick

Also includes merge resolution from 4c3ac80.

Allow loading of global service plugins via the CORBA interface of each TaskContextProxy
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants