Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change component loader behaviour to consider a component found on first valid path #288

Merged
merged 1 commit into from
May 6, 2019

Conversation

francisco-miguel-almeida
Copy link
Contributor

Fixes issue #161.

@meyerj
Copy link
Member

meyerj commented May 6, 2019

For reference: This PR implements what has been proposed in #161 (comment).

It would be an option to simply load a package from the first path found in ComponentLoader::importInstalledPackage(). This should fix the overlay semantics of the import() operation and would not break the component or typekit overwrite behavior of a subsequent import call of another package.

So if a package exists with the same name in multiple directories in the RTT_COMPONENT_PATH (e.g. catkin overlay and underlay), only the first one is imported (prefer overlay). If packages with different names provide component types, service plugins or Orocos types with conflicting names (e.g. name clashes or renamed package in one workspace), the inconsistent overlay semantics described in #161 (comment) still apply.

Copy link
Member

@meyerj meyerj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@meyerj meyerj merged commit 93db31f into master May 6, 2019
@meyerj meyerj deleted the fix/component-path branch May 6, 2019 16:13
meyerj added a commit that referenced this pull request May 6, 2019
… 2.9.1

Change component loader behaviour to consider a component found on first valid path
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants