Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: center text on OIDC buttons and debounce state update #366

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jonas-jonas
Copy link
Member

  1. centers the text on OIDC buttons - mainly to comply with Apple brand guidelines
  2. adds a debounce to the state update on click, to work around Safari issues. Related to fix: safari click handler and redirect handling #361

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 50.68%. Comparing base (f3fad4d) to head (61e6b3a).
Report is 40 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   42.43%   50.68%   +8.25%     
==========================================
  Files         136      139       +3     
  Lines        2008     2113     +105     
  Branches      288      312      +24     
==========================================
+ Hits          852     1071     +219     
+ Misses       1149     1030     -119     
- Partials        7       12       +5     
Components Coverage Δ
@ory/elements-react 47.48% <44.23%> (+10.69%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant