Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

List API: namespace should not be required anymore #761

Closed
zepatrik opened this issue Oct 8, 2021 · 8 comments · Fixed by #796
Closed

List API: namespace should not be required anymore #761

zepatrik opened this issue Oct 8, 2021 · 8 comments · Fixed by #796
Labels
good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one. tests Affects tests.
Milestone

Comments

@zepatrik
Copy link
Member

zepatrik commented Oct 8, 2021

Describe the bug

The namespace parameter is marked as required in the API spec. Also, we need a test to ensure that queries across namespaces actually work.

Expected behavior

Make the namespace parameter not required anymore. Make sure that all docs are updated accordingly.

@zepatrik zepatrik added help wanted We are looking for help on this one. good first issue A good issue to tackle when being a novice to the project. docs tests Affects tests. labels Oct 8, 2021
@Lakshay-Pruthi
Copy link

Lakshay-Pruthi commented Oct 12, 2021

@zepatrik Hey I'm a beginner and I would like to work on this issue.

@zepatrik
Copy link
Member Author

Sure, so important parts are:

  1. Add tests to ensure that handlers work without the namespace parameter. Should be relationtuple list handlers only IIRC.
  2. Update the swagger comments to make the namespace parameter optional. You will find examples of required/optional parameters around. Then run make sdk and update the internal/e2e tests.
  3. Look into the docs samples and docs in general whether there is any reference to the namespace being required.

@dhiemaz
Copy link
Contributor

dhiemaz commented Oct 31, 2021

Is this issue still open?

@zepatrik
Copy link
Member Author

zepatrik commented Nov 2, 2021

Yes

@dhiemaz
Copy link
Contributor

dhiemaz commented Nov 2, 2021

Okay, I want to help with this issue if it is still open.

@vancanhuit
Copy link
Contributor

Is there anyone working on this issue?

@dhiemaz
Copy link
Contributor

dhiemaz commented Dec 7, 2021

@vancanhuit it is still open, if you are willing to help with this then the floor is yours..

@vancanhuit
Copy link
Contributor

Okay. I can take this issue. 🙂

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one. tests Affects tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants