Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: namespace should not be required in List API #796

Merged
merged 3 commits into from
Dec 13, 2021
Merged

fix: namespace should not be required in List API #796

merged 3 commits into from
Dec 13, 2021

Conversation

vancanhuit
Copy link
Contributor

@vancanhuit vancanhuit commented Dec 12, 2021

Related issue(s)

Closes #761

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

I will review the docs and update it accordingly later.

@vancanhuit vancanhuit requested a review from zepatrik as a code owner December 12, 2021 06:59
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍
There is just one small thing I would improve.

Comment on lines 216 to 218
WithMaxDepth(func(n int64) *int64 {
return &n
}(int64(depth))),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WithMaxDepth(func(n int64) *int64 {
return &n
}(int64(depth))),
WithMaxDepth(pointerx.Int64(int64(depth))),

@zepatrik zepatrik merged commit 07be82e into ory:master Dec 13, 2021
@vancanhuit vancanhuit deleted the list-api/namespace-not-required branch December 13, 2021 13:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List API: namespace should not be required anymore
2 participants