Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: faster tests #1266

Merged
merged 2 commits into from
Mar 2, 2023
Merged

test: faster tests #1266

merged 2 commits into from
Mar 2, 2023

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Mar 2, 2023

Eliminating a 15s timeout, all short tests now take 8s (from 20s) on my machine.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from zepatrik as a code owner March 2, 2023 08:09
@hperl hperl self-assigned this Mar 2, 2023
@hperl hperl added the tests Affects tests. label Mar 2, 2023
@hperl hperl force-pushed the hperl/faster-tests branch from efd142f to 6c649df Compare March 2, 2023 08:10
@zepatrik zepatrik added this pull request to the merge queue Mar 2, 2023
Merged via the queue into master with commit b41bfb8 Mar 2, 2023
@zepatrik zepatrik deleted the hperl/faster-tests branch March 2, 2023 11:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tests Affects tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants