fix: docker compose migrate not working (#773) #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align the docker-compose with the ENTRYPOINT and CMD of the Dockerfile Use exec form in docker-compose as in the Dockerfile.
Use `docker-compose -f docker-compose-postgres.yml up` to test it
|
|
ogomezm
changed the title
ogomezm
changed the title
|
Thank you, this looks great! Could you please sign the CLA (just two clicks), then we can merge it right away! |
|
Ok, I have signed it already. |
|
Hello @ogomezm |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request closes #773
The issue is related to the ENTRYPONT and the CMD within the Dockerfile, both are using the exec format
["keto"]and["serve"]. That forces the usage of exec form instead of the bash form into the docker-compose commands["migrate", "up", "-y"]In addition to that, a new config folder with a default
keto.ymlfile has been added to the repository so as to be able to test the docker-compose.Use
docker-compose -f docker-compose-postgres.yml upto test PostgreSQL.MySQL docker-compose has been tested and not working yet.