Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: query selector on target element #165

Merged
merged 3 commits into from
Feb 21, 2024
Merged

chore: query selector on target element #165

merged 3 commits into from
Feb 21, 2024

Conversation

NoamAnisfeld
Copy link
Contributor

@NoamAnisfeld NoamAnisfeld commented Feb 18, 2024 •
edited by baruchiro
Loading

Fix #164

baruchiro
baruchiro reviewed Feb 18, 2024
View reviewed changes
baruchiro
baruchiro approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and welcome!

@baruchiro baruchiro enabled auto-merge February 20, 2024 17:51
@baruchiro baruchiro changed the title resolve https://github.com/os-scar/overlay/issues/164 chore: query selector on target element Feb 21, 2024
@baruchiro baruchiro disabled auto-merge February 21, 2024 09:18
@baruchiro baruchiro merged commit 218acc9 into os-scar:master Feb 21, 2024
3 of 5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@baruchiro baruchiro baruchiro approved these changes

Assignees

@NoamAnisfeld NoamAnisfeld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential issue of incorrect logic in the waitForElement util
2 participants
@NoamAnisfeld @baruchiro