Fix GetPacketID assertion failure in src/Hooks.cpp #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there is no need to terminate the program if the packet length is short |
|
somebody is now exploiting this to crash servers. |
ADRFranklin
reviewed
Jan 18, 2025
|
You are right, we should not be asserting this and killing the process because of a bad packet. It should be ignored. Not sure why this managed to go unnoticed for so long. Thanks for the PR |
|
I just put the log to confirm and identify . i removed it ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an assertion failure in
GetPacketIDlocated insrc/Hooks.cpp.The assertion p->length > sizeof(unsigned char) + sizeof(unsigned long)` was failing due to incorrect handling of packet lengths. This fix ensures the packet length is properly validated before accessing the data.
samp03svr: /home/michael/repos/SKY/src/Hooks.cpp:148: BYTE GetPacketID(Packet*): Assertion `p->length > sizeof(unsigned char) + sizeof(unsigned long)' failed.
zsh: IOT instruction ./samp03svr
I know that this is caused by a crasher.