init: add terminfo dirs when installing GAPs browse #1891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got hit by this error in the CI for
libpolymake_julia
here with the following error:After various experiments I was able to reproduce this locally, but only when the Browse package does not already exist in
~/.julia/gaproot/v4.12/pkg/Browse-1.8.20
(either runningmake clean
in the folder or removing it might help). The first try to start Oscar then fails with the above error, retrying it a second time works fine, the reason is probably that once it is installed the Browse package is loaded duringinitialize
viaGAP.jl
which does use the samewithenv
that I am adding here, see here.I still don't understand why this only appeared now when trying to update
polymake_jll
as this should always be required when loading Browse (i.e.Ncurses_jll
).On a different machine I was unable to reproduce this because Browse failed to install because it couldn't find
panel.h
, it does seem to only search in the system include and library directories when building it according, e.g.:Once Oscar is running one can see that the system-ncurses library seems to get pulled in addition to the jll version:
This probably contributes to this not being a more widespread problem.
And I guess all this will be irrelevant once we finally get a jll for Browse.
cc: @fingolfin
PS:
I also need this branch (with this name) to check whether this change fixes the CI mentioned at the beginning.Tests done.Edit: Tests are successful now for libpolymake_julia when using this downstream branch.