Ak96/ci contrib list #393
Merged
Ak96/ci contrib list #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, things appear to Please have a look and let us know what you think @fingolfin |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR enable a bot to make PRs like #392 . This can be merged once we figure out what to do with the "continue case", i.e., if a commit was made by someone in git, but pushed by someone else to github, the github API returns the author of the commit as
None. Currently we skip cases like this, but this should be handled. ( cf.etc/update-contributors.py:75| currently happens with['Jens Brandt', 'jens.brandt@rwth-aachen.de]), and he is not included in the contributor's list (mostly so we can reproduce the problem).cc @HereAround