Rewrite ascii mode switch logic #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goofyz 我用虚拟机测试的，确实是非常慢，你试一下编译为 release 版本的速度吧 |
|
release 版平均也要 200ms |
我这边真机 debug 都只需要 5ms，WP 使用虚拟机+debug 也只要几十ms，可能还是手机的问题。 这个 pr 只是修复 ascii_mode 切换 bug。 以后可以写个专门的符号键盘，不通过 rime 直接上屏，可以避免这个问题。 |
|
@goofyz 再看看吧，逻辑应该没问题了，性能我没法解决 |
|
在我的機子是慢了。不過也可以接受。 |
WhiredPlanck
approved these changes
May 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
重写 ascii_mode 切换逻辑，记住每个键盘布局的 ascii_mode
Issue tracker
Fixes will automatically close the related issues
Fixes #1092
Fixes #1028
Fixes #1035
Feature
Describe features of this pull request
Code of conduct
Style lint
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info