This repository has been archived by the owner on Jul 4, 2020. It is now read-only.
Move schema definitions to their classes. #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Some needed Constants | ||
| */ | ||
| public interface Constants { |
There was a problem hiding this comment.
We should not delete this interface. Please add @Deprecated with a message that this interface will be removed in a future release and the constants moved to the specific classes.
There was a problem hiding this comment.
I agree. I did that. Thanks for spotting.
This commit moves the schema constants to the classes they belong to. This also helps us to get rid of the Constants interface.
wallner
force-pushed
the
remove_constants
branch
from
4c12ed3 to
f501a00
Compare
|
Thanks! |
dacrome
added a commit
that referenced
this pull request
Sep 14, 2015
Move schema definitions to their classes.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the schema constants to the classes they belong to.
This also helps us to get rid of the Constants interface. Fixes #149