Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

performance profiling on the 'doubles' branch #237

Closed
spyhunter99 opened this issue Jan 7, 2016 · 5 comments
Closed

performance profiling on the 'doubles' branch #237

spyhunter99 opened this issue Jan 7, 2016 · 5 comments

Comments

@spyhunter99
Copy link
Collaborator

PR #48 has been integrated into the branch 'doubles'. This should hopefully provide better accuracy when setting the map extents and when plotting points. Since this is a large change, I'd love for someone to run some kind of performance impact analysis on this to find out if it's worth it or not.

It may actually be better to do the same type of branch with floats as the accuracy of floats may be good enough

and i don't want to do it ;)

maybe @ZKjellberg will take on the challenge!

@ZKjellberg
Copy link
Contributor

What type of performance analysis would you be looking to test? Android Studio has a lot of nice tools for testing performance. Would this be mostly a memory related issue? If so, the Memory Monitor could be an easy way for a quick glimpse of the impact. I would expect a sample such as the Military Icons fragment sample would be a good test?

(NOTE: Their direction to use the Memory Monitor refers to a non-existant Tools/Android option. I suggest clicking on the 6: Android Monitor window in the bottom left corner and selecting the Memory tab. If you see 'No Debuggable Application', access Tools/Android/Enable ADB Integration. This is a common problem if you have multiple Android Studio sessions.)

@ZKjellberg
Copy link
Contributor

Here are some images from the Memory Monitor with a comparison between master & doubles. You can also see CPU & GPU performance with the tool if desired.

@spyhunter99
Copy link
Collaborator Author

perfect. so we're looking at at least an extra 10 megs of ram. that's not
too terrible

On Thu, Jan 7, 2016 at 4:35 AM, Zachary Kjellberg notifications@github.com
wrote:

Here are some images from the Memory Monitor with a comparison between
master & doubles http://imgur.com/a/DPor4. You can also see CPU & GPU
performance with the tool if desired.


Reply to this email directly or view it on GitHub
#237 (comment).

@spyhunter99
Copy link
Collaborator Author

i guess the work from here is whether or not we find a way to reduce the memory foot print. 10MB seems a bit high IMO. A double is 8 bytes, integer is 4 bytes. That means we had at least 10MB's worth of integers previously, which is 2.5 million ints. Again, it seems high

@kjeremy
Copy link
Contributor

kjeremy commented Mar 30, 2016

@spyhunter99 Looking at the screenshot it looks to only be an increase of 3-4MB.

spyhunter99 added a commit that referenced this issue Jun 12, 2016
…ast 20. it's overflowing on the y coordinate of android's view system.

#296 related issue
#237 related issue
#46 root issue
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants