✨ Switched API release links to non-API release links #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klbynum
requested review from
naveensrinivasan and
justaugustus
and removed request for
a team
|
/scdiff generate Signed-Releases |
klbynum
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Thank you! Can you please fix the DCO status? We cannot merge without it.
You can find remediation steps here: https://github.com/ossf/scorecard/pull/4290/checks?check_run_id=28478870940
Co-authored-by: Silas Morgan <victorsmorgan@gmail.com> Co-authored-by: Jordin Jones <j.a.jones107732@spartans.nsu.edu> Signed-off-by: Kemon Bynum <monbynum51@icloud.com>
|
Hey @spencerschrock, thank you for taking a look at this PR. We followed the remediation steps and passed the DCO check. |
klbynum
temporarily deployed
to
integration-test
GitHub Actions
Inactive
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces a feature change for the release links generated by the following command:
go run main.go --repo ossf/scorecard --checks Signed-Releases --format json --show-details | jqWhat is the current behavior?
When running command to view releases, links display API format
What is the new behavior (if this is a feature change)?**
When running command to view releases, links display non-API format
Which issue(s) this PR fixes
Fixes #4030
Special notes for your reviewer
Did not add test for changes but ran current test
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)