2.0release support HLS AES encryption #1150
Conversation
| /** | ||
| * convert data string to hex. | ||
| */ | ||
| extern char *ff_data_to_hex(char *buff, const uint8_t *src, int s, int lowercase); |
There was a problem hiding this comment.
copy from ffmpeg?
FFmpeg code is LGPL, SRS is MIT, The License is conflicting.
There was a problem hiding this comment.
We couldn't accept GPL/LGPL code because SRS is MIT.
There was a problem hiding this comment.
I saw that the function ff_hex_to_data and ff_hex_to_data come from the same source ?? is that right?then I need to rewrite this function under MIT license??
There was a problem hiding this comment.
You should rewrite all code by yourself if it comes from FFMPEG or other GPL/LGPL projects.
Codes from MIT, BSD or Apache projects are ok.
There was a problem hiding this comment.
@winlinvip that's okay
There was a problem hiding this comment.
@winlinvip What is the define of "rewrite",you know that the basic logic of the function must be the same.
There was a problem hiding this comment.
You can read the RFC then write code by yourself. You can use FFMPEG to verify your result. We should never copy code from FFMEPG.
|
You should remove @T-bagwell Could you please help to check all codes are OK?
|
|
hi @winlinvip I found ff_hex_to_data is used in srs_rtsp_stack.cpp for other features, so I think it should also be rewritten ,I can do it when I have time... |
|
I will remove it. |
|
BTW, SRS2.0 is released, this feature will be merged to SRS3. |
|
In SRS3, I have removed the GPL/LGPL functions, like |
|
@winlinvip I merged relevant codes from 2.0 to 3.0 and a PR is already established. |
|
SRS3 will support this feature. #1109 |
No description provided.