some commits #2169

duiniuluantanqin · 2021-01-25T08:15:05Z

add statistic info for webrtc play
for #2149

Develop

winlinvip · 2021-01-27T03:05:49Z

👍

duiniuluantanqin · 2021-01-28T02:33:07Z

@winlinvip This commit (add kbps statistic for webrtc play 2b2b6c1) added the kbps statistic feature, only for webrtc play functionality.

TRANS_BY_GPT3

ghostsf · 2021-02-03T07:36:54Z

This webrtc live streaming is not good, right?

TRANS_BY_GPT3

duiniuluantanqin · 2021-02-03T09:33:33Z

This webrtc live streaming is not good, right?

Streaming hasn't been added, do you need to use it?

TRANS_BY_GPT3

codecov-io · 2021-02-04T07:45:31Z

Codecov Report

Merging #2169 (7c68834) into develop (10205e8) will increase coverage by 0.04%.
The diff coverage is 15.68%.

@@             Coverage Diff             @@
##           develop    #2169      +/-   ##
===========================================
+ Coverage    56.25%   56.29%   +0.04%     
===========================================
  Files          125      125              
  Lines        54374    54417      +43     
===========================================
+ Hits         30586    30633      +47     
+ Misses       23788    23784       -4

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_listener.cpp | 11.15% <0.00%> (-0.30%) | ⬇️ |
| trunk/src/app/srs_app_rtc_api.cpp | 0.00% <0.00%> (ø) | |'

Translated to English while maintaining the markdown structure:

| trunk/src/app/srs_app_rtc_api.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_rtc_source.cpp | 11.25% <0.00%> (-0.05%) | ⬇️ |
| trunk/src/app/srs_app_rtc_conn.cpp | 9.25% <44.44%> (+0.35%) | ⬆️ |
| trunk/src/protocol/srs_rtmp_stack.cpp | 89.05% <0.00%> (+0.04%) | ⬆️ |
| trunk/src/protocol/srs_service_utility.cpp | 72.97% <0.00%> (+0.54%) | ⬆️ |
| trunk/src/app/srs_app_statistic.cpp | 8.76% <0.00%> (+8.76%) | ⬆️ |

Continue to review full report at Codecov.

Legend - Click here to learn more
| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Translated to English while maintaining the markdown structure:

| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Powered by Codecov. Last update 10205e8...7c68834. Read the comment docs.

TRANS_BY_GPT3

duiniuluantanqin · 2021-02-04T07:47:04Z

This webrtc live streaming is not good, right?

Add statistic info for webrtc publish has also been added for live streaming.

TRANS_BY_GPT3

winlinvip · 2021-04-15T08:36:34Z

trunk/src/app/srs_app_listener.hpp

@@ -134,9 +135,12 @@ class SrsTcpListener : public ISrsCoroutineHandler
 };

 // TODO: FIXME: Rename it. Refine it for performance issue.
-class SrsUdpMuxSocket
+class SrsUdpMuxSocket : public ISrsProtocolStatistic


The structure of 'SrsUdpMuxSocket' is unreasonable and too large. It will be split in version 4.0. Therefore, the corresponding statistics may be better implemented after the split.

TRANS_BY_GPT3

winlinvip · 2021-04-15T08:37:49Z

trunk/src/app/srs_app_rtc_api.cpp

-        string tcUrl;
-        srs_parse_rtmp_url(streamurl, tcUrl, stream_name);
+    string tcUrl;
+    srs_parse_rtmp_url(streamurl, tcUrl, stream_name);


Every time I see the URL, I want to make changes to it. This part also needs to be improved before it is suitable for statistics.
Originally, there was only RTMP URL, but now it would be better to use HTTP URL specification.
There are also many and miscellaneous functions for parsing the URL, which need to be improved for better performance.

TRANS_BY_GPT3

codecov-commenter · 2021-04-21T02:16:28Z

Codecov Report

Merging #2169 (a98d60f) into develop (efdbf37) will decrease coverage by 4.41%.
The diff coverage is 8.00%.

❗ Current head a98d60f differs from pull request most recent head 6355038. Consider uploading reports for the commit 6355038 to get more accurate results

@@             Coverage Diff             @@
##           develop    #2169      +/-   ##
===========================================
- Coverage    42.74%   38.32%   -4.42%     
===========================================
  Files          101      108       +7     
  Lines        35972    40187    +4215     
===========================================
+ Hits         15376    15402      +26     
- Misses       20596    24785    +4189

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_listener.cpp | 10.69% <0.00%> (+0.95%) | ⬆️ |
| trunk/src/app/srs_app_rtc_api.cpp | 0.00% <0.00%> (ø) | |'

Translated to English while maintaining the markdown structure:

| trunk/src/app/srs_app_rtc_api.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_rtc_source.cpp | 12.15% <0.00%> (+4.17%) | ⬆️ |
| trunk/src/app/srs_app_statistic.cpp | 8.39% <0.00%> (+8.39%) | ⬆️ |
| trunk/src/app/srs_app_rtc_conn.cpp | 9.87% <42.10%> (+0.40%) | ⬆️ |
| trunk/src/kernel/srs_kernel_log.cpp | 75.00% <0.00%> (-25.00%) | ⬇️ |
| trunk/src/app/srs_app_hourglass.cpp | 12.26% <0.00%> (-7.35%) | ⬇️ |
| trunk/src/app/srs_app_log.cpp | 9.02% <0.00%> (-3.76%) | ⬇️ |
| trunk/src/app/srs_app_config.cpp | 64.63% <0.00%> (-2.36%) | ⬇️ |
| trunk/src/kernel/srs_kernel_flv.cpp | 96.42% <0.00%> (-1.63%) | ⬇️ |
| ... and 104 more | |

Continue to review full report at Codecov.

Legend - Click here to learn more
| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Translated to English while maintaining the markdown structure:

| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Powered by Codecov. Last update efdbf37...6355038. Read the comment docs.

TRANS_BY_GPT3

add http hook callback for webrtc;

winlinvip · 2021-05-12T13:30:15Z

The client stat bug #2311 fixed by 71dda68

winlinvip · 2021-08-27T00:12:23Z

This PR should be able to be closed, I see there are other PRs.

TRANS_BY_GPT3

duiniuluantanqin and others added 2 commits January 22, 2021 11:50

Merge pull request #6 from ossrs/develop

0ed02e3

Develop

add statistic info for webrtc play

361f24c

duiniuluantanqin mentioned this pull request Jan 25, 2021

WebRTC: Statistics similar to chrome://webrtc-inernals. #2149

Closed

chenhaibo added 3 commits January 27, 2021 17:58

add gitignore

871b463

上传vs工程

5cb9019

add kbps statistic for webrtc play

2b2b6c1

chenhaibo added 2 commits February 4, 2021 15:44

add statistic info for webrtc publish

1d0679d

make -j8

7c68834

Merge branch 'develop' into develop

45a334d

winlinvip force-pushed the develop branch from 494c82a to 7d12c36 Compare March 4, 2021 07:04

clean up inactived stream in statistic

d286091

winlinvip reviewed Apr 15, 2021

View reviewed changes

chenhaibo added 2 commits April 21, 2021 10:06

merge

1b768cc

Merge branch 'develop' of https://github.com/ossrs/srs into srs_pr

5f1493c

chenhaibo added 7 commits April 21, 2021 11:34

Merge branch 'develop' of https://github.com/ossrs/srs into srs_pr

4b85417

Merge branch 'develop' of https://github.com/ossrs/srs into srs_pr

eae6e33

fix merge bug

a98d60f

vs setting

da9b2df

add class SrsHttpHooksController;

d4c145e

add http hook callback for webrtc;

add function expire in class SrsRtcConnection, for kick-off

340c066

merge

968ab17

chowyu08 approved these changes May 6, 2021

View reviewed changes

chenhaibo added 2 commits May 8, 2021 15:31

fix bug // @see ossrs#2311

497c2d5

support for mutiple sps/pps parsing

a0c09d8

duiniuluantanqin changed the title ~~add statistic info for webrtc play~~ some commits May 10, 2021

chenhaibo added 2 commits May 11, 2021 10:05

fix this commit bug (ossrs@497c2d5)

6689d88

merge and resolve conflict

fec44ba

chenhaibo added 4 commits May 14, 2021 16:55

fix bug //@see ossrs#2311

d5b28ad

merge

c57cbfa

fix compile error

e03ce10

Merge branch 'develop' of https://github.com/ossrs/srs into srs_pr

7c8f728

duiniuluantanqin force-pushed the develop branch from 0521dab to 7c8f728 Compare May 20, 2021 01:51

chenhaibo added 5 commits May 20, 2021 10:27

Merge branch 'develop' of https://github.com/ossrs/srs into srs_pr

a3afa9f

fix bug

77c27ff

merge

ca8e1bf

同步

7442319

Merge branch 'develop' of https://github.com/ossrs/srs into srs_pr

6355038

winlinvip closed this Aug 27, 2021

winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

some commits #2169

some commits #2169

duiniuluantanqin commented Jan 25, 2021

winlinvip commented Jan 27, 2021

duiniuluantanqin commented Jan 28, 2021 •

edited by winlinvip

Loading

ghostsf commented Feb 3, 2021 •

edited by winlinvip

Loading

duiniuluantanqin commented Feb 3, 2021 •

edited by winlinvip

Loading

codecov-io commented Feb 4, 2021 •

edited by winlinvip

Loading

duiniuluantanqin commented Feb 4, 2021 •

edited by winlinvip

Loading

winlinvip Apr 15, 2021 •

edited

Loading

winlinvip Apr 15, 2021 •

edited

Loading

codecov-commenter commented Apr 21, 2021 •

edited by winlinvip

Loading

winlinvip commented May 12, 2021 •

edited

Loading

winlinvip commented Aug 27, 2021 •

edited

Loading

some commits #2169

some commits #2169

Conversation

duiniuluantanqin commented Jan 25, 2021

winlinvip commented Jan 27, 2021

duiniuluantanqin commented Jan 28, 2021 • edited by winlinvip Loading

ghostsf commented Feb 3, 2021 • edited by winlinvip Loading

duiniuluantanqin commented Feb 3, 2021 • edited by winlinvip Loading

codecov-io commented Feb 4, 2021 • edited by winlinvip Loading

Codecov Report

duiniuluantanqin commented Feb 4, 2021 • edited by winlinvip Loading

winlinvip Apr 15, 2021 • edited Loading

Choose a reason for hiding this comment

winlinvip Apr 15, 2021 • edited Loading

Choose a reason for hiding this comment

codecov-commenter commented Apr 21, 2021 • edited by winlinvip Loading

Codecov Report

winlinvip commented May 12, 2021 • edited Loading

winlinvip commented Aug 27, 2021 • edited Loading

duiniuluantanqin commented Jan 28, 2021 •

edited by winlinvip

Loading

ghostsf commented Feb 3, 2021 •

edited by winlinvip

Loading

duiniuluantanqin commented Feb 3, 2021 •

edited by winlinvip

Loading

codecov-io commented Feb 4, 2021 •

edited by winlinvip

Loading

duiniuluantanqin commented Feb 4, 2021 •

edited by winlinvip

Loading

winlinvip Apr 15, 2021 •

edited

Loading

winlinvip Apr 15, 2021 •

edited

Loading

codecov-commenter commented Apr 21, 2021 •

edited by winlinvip

Loading

winlinvip commented May 12, 2021 •

edited

Loading

winlinvip commented Aug 27, 2021 •

edited

Loading