Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refuse edge request when state is stopping #2707

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

duiniuluantanqin
Copy link
Member

@duiniuluantanqin duiniuluantanqin commented Nov 3, 2021

Question: Edge: After the last pull stream is disconnected, if the same stream is requested again within 3 seconds, it cannot be played smoothly. (#2215)
Analysis: When the stream is requested again within 3 seconds, the state is in the stopping state.
Solution: When in the stopping state, return an error and provide the user with a clear prompt.

TODO: @IAmCodingCoding has provided an optimized solution that allows for quick exit without waiting for 3 seconds. See #2215 (comment).


TRANS_BY_GPT3

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #2707 (79b0929) into develop (0d8b2df) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2707      +/-   ##
===========================================
- Coverage    59.98%   59.98%   -0.01%     
===========================================
  Files          121      121              
  Lines        51046    51048       +2     
===========================================
  Hits         30619    30619              
- Misses       20427    20429       +2     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_edge.cpp | 0.00% <0.00%> (ø) | |

'

Translated to English while maintaining the markdown structure:

'| trunk/src/app/srs_app_edge.cpp | 0.00% <0.00%> (ø) | |


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data'

Translated to English while maintaining the markdown structure:

'> Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 0d8b2df...79b0929. Read the comment docs.

TRANS_BY_GPT3

@xiaozhihong
Copy link
Collaborator

xiaozhihong commented Nov 3, 2021

st_sleep 3 seconds is to prevent excessive retries, so the current best practice is to provide clear instructions.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

NICE @duiniuluantanqin @xiaozhihong

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
4 participants