Feature/retry logic in es2plus client #964
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the timeout for requests set to in the HttpClient? |
|
Timeout is set to ten seconds: |
vihangpatil
reviewed
Nov 28, 2019
There was a problem hiding this comment.
The connection timeout issue can be fixed with just a one-line change in the config.
The current value of 10s is set to timeout.
connectionTimeout is not set at all and hence defaults to 500ms.
Please try that in a separate PR before this elaborate solution.
Reference:
https://www.dropwizard.io/en/stable/manual/configuration.html#httpclient
|
Have submitted a new one-line PR with the change suggested by @vihangpatil. If that does the trick, I will rework this PR into a pure refactoring PR (adding documentation etc.), and remove the retry logic. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature to fix bug/misfeature: Some times the ES2+ responds slowly, and this patch gives the client a little more time to get it right before signalling a failure.
Also some refactoring/additional documentation (based on hints from Intellij which checks for such things before committing to VCS).