Skip to content

Use new ESLint API #654

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Use new ESLint API #654

merged 3 commits into from
Oct 9, 2023

Conversation

ota-meshi
Copy link
Owner

@ota-meshi ota-meshi commented Oct 8, 2023

This PR refactors to use the new API instead of the old ESLint API.

See https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/

They are also present in the minimum version we support.

@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2023

🦋 Changeset detected

Latest commit: 17de9c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-regexp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RunDevelopment
Copy link
Collaborator

Code looks good, but I'm a bit worried about updating eslint and @types/eslint. Wouldn't this enable us to use newer API functions than our minimum supported ESLint version? I'm not sure if this will be an issue, but ideally we could use TS to enforce our minimum supported ESLint version. What do you think?

@ota-meshi
Copy link
Owner Author

I think we should use eslint@8.44.0 as you say 👍
I made sure that eslint@8.44.0 and @types/eslint@8.44.0 are used in package-lock.json so that we can use eslint@8.44.0 in our tests.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants