Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add namespace explicitly #124

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Add namespace explicitly #124

merged 4 commits into from
Dec 11, 2024

Conversation

CiraciNicolo
Copy link
Contributor

@CiraciNicolo CiraciNicolo commented Dec 5, 2024

Summary of changes:

The rationale behind this PR is that there are cases where it becomes quite complicated to deploy the application unless the namespace is explicitly provided — for example, when managing the application using a GitOps approach.

Checklist:

  • I updated the artifacthub.io/changes annotation in Chart.yml according to the documentation
  • Optional: I updated in README.md the Helm Values

Signed-off-by: Nicolò Ciraci <ciraci.nicolo@gmail.com>
Signed-off-by: Nicolò Ciraci <ciraci.nicolo@gmail.com>
@CiraciNicolo CiraciNicolo changed the title Fix(namespace) Add namespace explicitly Dec 5, 2024
Signed-off-by: Nicolò Ciraci <ciraci.nicolo@gmail.com>
Signed-off-by: Nicolò Ciraci <ciraci.nicolo@gmail.com>
@jdetroyes jdetroyes added the enhancement New feature or request label Dec 6, 2024
@jdetroyes jdetroyes self-assigned this Dec 6, 2024
@jdetroyes
Copy link
Contributor

Hello @CiraciNicolo

Thanks for your contribution, one thing before merging, why did you add a separator in each .yaml files?

@CiraciNicolo
Copy link
Contributor Author

Hi @jdetroyes, by specs a YAML file should start with "---"; it can be optional tho if no more than a document is present. It's just a preferred way. If you prefer, I can remove it.

@jdetroyes jdetroyes merged commit efd9875 into otwld:main Dec 11, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants