Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring our LM Harness integration code (specifically the mapping and setting of
lm_eval.simple_evaluate
'smodel_args
, in preparation for resolving GH issue 1358 (support for Remote vLLM with LM Harness)Why the refactor?
The model args are added all over the place (in
model_params.py
, inlm_harness.py
atevaluate
and_create_extra_lm_harness_model_params_for_vlm
) and it's becoming increasingly buggy to track what has been added for 5 different engines and 2 modalities. Thus, aggregated everything in a single function, documented what params the 4-5 LH Harness engines currently support, the mapping from Oumi's var names, etc.Related issues
Fixes OPE-940
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staff
is required.