Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improvements to #26 - replace context for explicit props, remove duplicate state, fix creation of a new proposal #27

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Improvements to #26 - replace context for explicit props, remove duplicate state, fix creation of a new proposal #27

merged 2 commits into from
Jun 21, 2024

Conversation

oveddan
Copy link
Contributor

@oveddan oveddan commented Apr 22, 2024 •
edited
Loading

  • Better naming around provider updating/namely: addAction and replaceProposal
  • Replace ProviderContext with explicit prop passing; remove duplicate proposal state and just have query string be source of truth
  • Fix some type failing issues
  • When there is no current proposal, and a user is to be added/removed from the safe, redirect to a new url so that the url can be properly shared

@oveddan Graphite App
Copy link
Contributor Author

oveddan commented Apr 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @oveddan and the rest of your teammates on Graphite Graphite

@oveddan oveddan changed the title * remove Proposal context for explicit prop passing. * Fix some typing issues Improvements to Upgrade Apr 22, 2024
@oveddan oveddan changed the title Improvements to Upgrade Improvements to #26 - replace context for explicit props, better function naming, type fixing Apr 22, 2024
@oveddan oveddan marked this pull request as ready for review April 22, 2024 18:45
@oveddan oveddan force-pushed the fix_url_generation_fixes branch 3 times, most recently from 115e0c4 to 2553af9 Compare April 22, 2024 19:26
@oveddan oveddan changed the title Improvements to #26 - replace context for explicit props, better function naming, type fixing Improvements to #26 - replace context for explicit props, remove duplicate state, fix creation of a new proposal Apr 22, 2024
@oveddan Graphite App
Copy link
Contributor Author

oveddan commented Jun 21, 2024 •
edited
Loading

Merge activity

  • Jun 21, 3:47 PM EDT: @oveddan started a stack merge that includes this pull request via Graphite.
  • Jun 21, 3:49 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 21, 3:50 PM EDT: @oveddan merged this pull request with Graphite.

@oveddan oveddan changed the base branch from fix_url_generation_editing_and_ownership_changes to main June 21, 2024 19:48
@oveddan oveddan force-pushed the fix_url_generation_fixes branch from 2553af9 to f21a03b Compare June 21, 2024 19:48
@oveddan oveddan merged commit f5dada2 into main Jun 21, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oveddan