Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add explicit void return type if set by user #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/outfoxx/typescriptpoet/FunctionSpec.kt
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ private constructor(
codeWriter.emitCode("]")
}

if (returnType != null && returnType != TypeName.VOID) {
if (returnType != null) {
codeWriter.emitCode(CodeBlock.of(": %T", returnType))
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ class FunctionSpecTests {
}

@Test
@DisplayName("Generates no return type when void")
fun testGenNoReturnTypeForVoid() {
@DisplayName("Generates return type when void")
fun testGenReturnTypeForVoid() {
val testClass = FunctionSpec.builder("test")
.returns(TypeName.VOID)
.build()
Expand All @@ -210,7 +210,7 @@ class FunctionSpecTests {
out.toString(),
equalTo(
"""
function test() {
function test(): void {
}

""".trimIndent()
Expand Down