Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add games that have no APK #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add games that have no APK #50

wants to merge 1 commit into from

Conversation

Szeraax
Copy link
Contributor

@Szeraax Szeraax commented Mar 25, 2020

@cweiske Please spot check 2-3 games to make sure that it looks right to you before I merge it in.

@Szeraax Szeraax requested a review from cweiske March 25, 2020 04:48
@cweiske
Copy link
Member

cweiske commented Mar 25, 2020

  • do not add products if they have no real data
  • "media: [1]" is not helpful
  • if you do not have any release data, then do not add releases
  • in general, do not add properties you have no data for, or add them with "FIXME" as value

cweiske
cweiske requested changes May 30, 2020
View reviewed changes
Copy link
Member

@cweiske cweiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We have the UUID for agameaweek, it's 8a1647c2-1d78-4c08-91cf-7916e720fd67
  • do not add products if you have no data for them
  • do not set "inAppPurchases": null,, better set them to "FIXME". same for genres and players
    (players: ["FIXME"], genres dito)
  • leave media an empty array instead of "media": [ 1 ],

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cweiske cweiske cweiske requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Szeraax @cweiske