Skip to content
This repository has been archived by the owner on Aug 6, 2021. It is now read-only.

Updated node version to v10 and removed v8 profiler #25

Merged
merged 1 commit into from
Jul 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.16.0
10.16.0
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:6.16.0 as app
FROM node:10.16.0 as app

WORKDIR /app

Expand All @@ -11,7 +11,7 @@ COPY . /app



FROM node:6.16.0
FROM node:10.16.0

COPY --from=app /app /app

Expand Down
13 changes: 6 additions & 7 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,12 @@ pipeline {
}
}

// should be enabled once Node version is updated to >=8
// stage('Linting') {
// steps {
// sh 'DOCKER_COMPOSE_FLAGS="-f docker-compose.ci.yml" make format'
// sh 'DOCKER_COMPOSE_FLAGS="-f docker-compose.ci.yml" make lint'
// }
// }
stage('Linting') {
steps {
sh 'DOCKER_COMPOSE_FLAGS="-f docker-compose.ci.yml" make format'
sh 'DOCKER_COMPOSE_FLAGS="-f docker-compose.ci.yml" make lint'
}
}

stage('Unit Tests') {
steps {
Expand Down
10 changes: 0 additions & 10 deletions app.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,6 @@ server.get('/status', (req, res) => res.send({ status: 'spelling api is up' }))

server.get('/health_check', HealthCheckController.healthCheck)

const profiler = require('v8-profiler')
server.get('/profile', function(req, res) {
const time = parseInt(req.query.time || '1000')
profiler.startProfiling('test')
return setTimeout(function() {
const profile = profiler.stopProfiling('test')
return res.json(profile)
}, time)
})

const host =
__guard__(
Settings.internal != null ? Settings.internal.spelling : undefined,
Expand Down
2 changes: 1 addition & 1 deletion buildscript.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
spelling
--node-version=6.16.0
--node-version=10.16.0
--script-version=1.1.21
--build-target=docker
--dependencies=mongo,redis
Expand Down
Loading