[Docker] Updated Dockerfile's #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have tested it and it works |
ksuprynowicz
added
bug
daleglass
requested changes
Feb 11, 2024
daleglass
requested changes
Feb 12, 2024
OfficialR3ido101
referenced
this pull request
in terminalx-resonite/overte-domain-server-docker
Feb 25, 2024
* trying to remove root #1 * tesitng * de-rooting 2 test * de-root test #2 * de-root #3 * added pyton3 de-root #4 * hardcode path de-root overte-org#5 * forced to only master de-root overte-org#5 * removed env arguments that are not needed. * temp check on dale's repo de-root overte-org#6 * forgot space * de-rooting * de-root * de-root * de-root overte-org#8 * removed builder image and get it ready for pr * removed unneeded stuff * Will this this to run * prepping the runtime dockerfile for overte-org
|
I have found a bug regarding ports not binding I will have a look at some point Update: I did not forward the ports when running |
daleglass
approved these changes
Feb 27, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow us to run the up to date code for Overte with the node version provided by VCPKG
Before this is merged I would recommend that @daleglass has a runner with a tag of self-hosted.