change specimen type and sample type to list #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blabadi
reviewed
May 26, 2020
...o-domain/src/main/java/bio/overture/maestro/domain/api/AnalysisCentricDocumentConverter.java
Show resolved
Hide resolved
|
can you update at least one analysis in the song payloads fixtures to have multiple samples or/and specimens to cover the new logic, I don't think that is covered the way tests are now |
this test covers the logic where there are multiple specimen and multiple samples: |
blabadi
approved these changes
May 27, 2020
Merged
blabadi
added a commit
that referenced
this pull request
Jun 10, 2020
release 3.0.0 #116 fix junit 5 version to avoid conflicts in class path #118 update analysis centric index fields, add data_type, rename files filed to file, remove data_path and metadata_path from repositories field #119 kafka stream listener configurable status (PUBLISHED, SUPPRESSED, wtv) #120 add support for cram/crai index files #121 change specimen type and sample type to list #127 update mappings fields #129 rename format to file_type #131 remove last_modified from file centric mapping #132 rename file-id to file-object_id #135 fix index analysis response message #136 add maven formatter #139 add ability to remove document by analysis id from analysis_centric #143 add dynamic info indexed field support to donor, Specimen, sample, and file update test document to cover that for file centric document #145 fix NPE for analysis centric index
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.