Improve goreport (#33)

Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>

api/handler/resolution.go

@@ -8,6 +8,7 @@ import (
 	"github.com/juju/errors"
 	"github.com/loopfz/gadgeto/zesty"
 	"github.com/sirupsen/logrus"
+
 	"github.com/ovh/utask"
 	"github.com/ovh/utask/engine"
 	"github.com/ovh/utask/engine/step"

api/middleware.go

@@ -6,6 +6,7 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/juju/errors"
 	"github.com/sirupsen/logrus"
+
 	"github.com/ovh/utask"
 	"github.com/ovh/utask/pkg/auth"
 )
@@ -52,7 +53,8 @@ func authMiddleware(authProvider func(*http.Request) (string, error)) func(c *gi
 				c.AbortWithError(http.StatusUnauthorized, err)
 				return
 			}
-			c.Set(auth.IdentityProviderCtxKey, user)
+			ctxKey := string(auth.IdentityProviderCtxKey)
+			c.Set(ctxKey, user)
 			c.Next()
 		}
 	}

cmd/utask/version.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 
 	"github.com/spf13/cobra"
+
 	"github.com/ovh/utask"
 )
 

engine/collector_retry.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/loopfz/gadgeto/zesty"
 	"github.com/sirupsen/logrus"
+
 	"github.com/ovh/utask"
 	"github.com/ovh/utask/db/pgjuju"
 	"github.com/ovh/utask/models/resolution"

engine/step/step.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/juju/errors"
 	"github.com/sirupsen/logrus"
+
 	"github.com/ovh/utask"
 	"github.com/ovh/utask/engine/values"
 	"github.com/ovh/utask/pkg/jsonschema"

engine/values/values.go

@@ -130,12 +130,12 @@ func (v *Values) GetError(stepName string) interface{} {
 	return v.getStepData(stepName, ErrorKey)
 }
 
-// SetChildren stores the error resulting from a failed step
+// SetError stores the error resulting from a failed step
 func (v *Values) SetError(stepName string, value interface{}) {
 	v.setStepData(stepName, ErrorKey, value)
 }
 
-// UnsetChildren empties the error from a failed step
+// UnsetError empties the error from a failed step
 func (v *Values) UnsetError(stepName string) {
 	v.unsetStepData(stepName, ErrorKey)
 }

pkg/auth/auth.go

@@ -12,6 +12,11 @@ import (
 	"github.com/ovh/utask/pkg/utils"
 )
 
+// CtxKey is a custom type based on string type
+// used to fix golint when IdentityProviderCtxKey
+// is set
+type CtxKey string
+
 // IdentityProviderCtxKey is the key used to store/retrieve identity data from Context
 const IdentityProviderCtxKey = "__identity_provider_key"
 
@@ -22,7 +27,7 @@ var (
 
 // WithIdentity adds identity data to a context
 func WithIdentity(ctx context.Context, id string) context.Context {
-	return context.WithValue(ctx, IdentityProviderCtxKey, id)
+	return context.WithValue(ctx, CtxKey(IdentityProviderCtxKey), id)
 }
 
 // Init reads authorization from configstore, bootstraps values

pkg/jsonschema/jsonschema.go

@@ -6,6 +6,7 @@ import (
 
 	"github.com/juju/errors"
 	"github.com/santhosh-tekuri/jsonschema"
+
 	"github.com/ovh/utask/pkg/utils"
 )
 

pkg/plugins/builtin/ssh/ssh.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/juju/errors"
 	"golang.org/x/crypto/ssh"
+
 	"github.com/ovh/utask/pkg/plugins/taskplugin"
 )
 

pkg/plugins/plugins.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/ovh/configstore"
 	"github.com/sirupsen/logrus"
+
 	"github.com/ovh/utask/api"
 	"github.com/ovh/utask/engine/step"
 )