-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
typos + broken links in documentation #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the version name in the Makefile
too?
changed version in Makefile |
What about directly get the value from the latest git tag? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why delete the LICENSE
file from github.com/wI2L/fizz
?
Signed-off-by: Pablo Pérez Schröder <2639770+nomonamo@users.noreply.github.com>
Signed-off-by: Pablo Pérez Schröder <2639770+nomonamo@users.noreply.github.com>
LICENSE file in fizz is a mistake :/ |
Signed-off-by: Pablo Pérez Schröder <2639770+nomonamo@users.noreply.github.com>
Signed-off-by: Pablo Pérez Schröder <2639770+nomonamo@users.noreply.github.com>
hack/generate-install-script.sh
Outdated
@@ -35,4 +35,8 @@ write_block "sql/schema.sql" sql/schema.sql | |||
echo "### TEMPLATES" >> $dst | |||
write_block "templates/hello-world-now.yaml" ./examples/templates/hello-world-now.yaml | |||
|
|||
version=`git describe --tags $(git rev-list --tags --max-count=1)` | |||
sed -i.bak "s/DOCKER_TAG/$version/" ./$dst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to create a backup file if it is deleted just after ;)
sed -i.bak "s/DOCKER_TAG/$version/" ./$dst | |
sed -i "s/DOCKER_TAG/$version/" ./$dst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incredible as it may sound, it's there for compatibility with mac os :|
https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux
hack/generate-install-script.sh
Outdated
@@ -35,4 +35,8 @@ write_block "sql/schema.sql" sql/schema.sql | |||
echo "### TEMPLATES" >> $dst | |||
write_block "templates/hello-world-now.yaml" ./examples/templates/hello-world-now.yaml | |||
|
|||
version=`git describe --tags $(git rev-list --tags --max-count=1)` | |||
sed -i.bak "s/DOCKER_TAG/$version/" ./$dst | |||
rm $dst.bak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm $dst.bak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment in the code, for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -i
option is not POSIX compliant. So you can't expect it to work everywhere.
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html
See #22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align typo on Makefile
should be fixed. Otherwise LGFM 👍
Signed-off-by: Pablo Pérez Schröder <2639770+nomonamo@users.noreply.github.com>
Signed-off-by: Pablo Pérez Schröder <2639770+nomonamo@users.noreply.github.com>
fix a couple of typos, update to latest version