Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rework email plugin #25

Merged
merged 11 commits into from
Nov 22, 2019
Merged

Rework email plugin #25

merged 11 commits into from
Nov 22, 2019

Conversation

w3st3ry
Copy link
Contributor

@w3st3ry w3st3ry commented Nov 18, 2019

I just wrote some code to replace the "homemade" way to send e-mail.
The PR contains the updated vendors.

Also related to #4

Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
@w3st3ry w3st3ry added enhancement New feature or request 👀 NEED REVIEW 👀 Issue or PR need a review labels Nov 18, 2019
@w3st3ry w3st3ry added this to the v1.1.0 milestone Nov 18, 2019
@w3st3ry w3st3ry self-assigned this Nov 18, 2019
Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
@w3st3ry w3st3ry requested a review from loopfz November 19, 2019 14:11
Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
Copy link
Contributor

@pablito-perez pablito-perez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a couple of details open for debate

README.md Outdated Show resolved Hide resolved
pkg/plugins/builtin/email/email.go Outdated Show resolved Hide resolved
pkg/plugins/builtin/email/email.go Outdated Show resolved Hide resolved
Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
Copy link
Contributor

@pablito-perez pablito-perez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ongoing discussion, nitpicking

pkg/plugins/builtin/email/email.go Outdated Show resolved Hide resolved
pkg/plugins/builtin/email/email.go Outdated Show resolved Hide resolved
Signed-off-by: Valentin Pichard <7628998+w3st3ry@users.noreply.github.com>
Copy link
Contributor

@pablito-perez pablito-perez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w3st3ry w3st3ry merged commit 9570f38 into master Nov 22, 2019
@w3st3ry w3st3ry deleted the rework-email branch November 22, 2019 13:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request 👀 NEED REVIEW 👀 Issue or PR need a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants