Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(conditions): allow running check on retryable states #547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Crocmagnon
Copy link

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This allows running check conditions on retryable states such as SERVER_ERROR, effectively giving better control to the execution flow.

A use case may be to retry only a couple times on specific non-critical steps.

This is a non-breaking change, the feature is only enable if a condition bears the specific boolean.

  • What is the current behavior? (You can also link to an open issue here)

Check conditions aren't run on retryable states, preventing users from controlling the execution flow in case of 5xx errors.

  • What is the new behavior (if this is a feature change)?

Check conditions marked with run_on_retryable will be evaluated even if the state is retryable.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

  • Other information:
    N/A

This allows running check conditions on retryable states
such as SERVER_ERROR, effectively giving better control to the
execution flow.

A use case may be to retry only a couple times on specific non-critical
steps.

This is a non-breaking change, the feature is only enable if a condition
bears the specific boolean.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant