-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix SecResponseBodyAccess and ctl:requestBodyAccess directives #1886
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix SecResponseBodyAccess and ctl:requestBodyAccess directives #1886
Conversation
@victorhora this PR is breaking current ModSecurity-nginx connector tests:
Looking into details now. |
@victorhora library tests are failing as well:
|
Funny @defanator, the tests were working for me before. There's a chance I've pushed the wrong code LOL :P. Let me have another a look at it |
Ok, I've pushed the wrong code :P Should be good now unless I screwed up again :P. @defanator If the buildbots pass, please let me know the results of ModSecurity-nginx connector tests. (I can see now we really need Travis integration for those :)) |
See the following issues for details: owasp-modsecurity/ModSecurity#1531 owasp-modsecurity/ModSecurity#1886
@victorhora yes, connector tests are now passing. I've just submitted an extension to the request body tests for nginx connector here: owasp-modsecurity/ModSecurity-nginx#124 (note that it should be merged after #1886 gets in the v3/master to avoid Travis failures) |
Merged! Thanks! |
See the following issues for details: owasp-modsecurity/ModSecurity#1531 owasp-modsecurity/ModSecurity#1886
See the following issues for details: owasp-modsecurity/ModSecurity#1531 owasp-modsecurity/ModSecurity#1886
Small change to allow for SecResponseBodyAccess and ctl:requestBodyAccess directives to work as intended. Should fix #1531.