Buildsystem fixes #3390
Buildsystem fixes #3390
Conversation
automake doesn't support wildcards. See https://www.gnu.org/software/automake/manual/html_node/Wildcards.html for details. Use the GNU make $(wildcard ) extension. Note: this breaks with non-GNU make
|
Hi @arvedarved, first of all, thank you for your first contribution! 🎉 Unfortunately there are a few issues in build processes in case of Linux and MacOS. Like this one - could you take a look at them? Thanks! |
Reported by: CI via Ervin Hegedus
|
|
Hi Ervin, Thanks for looking at the pull request. Indeed the change in the test directory looks dubious, I tried to fix it. |
|
Hi @arvedarved,
yes, the regression tests run automatically - normally. But while this is your first contribution, I have to approve the run. If you're done with it, and the PR will be merged, then your PR's will start the tests automatically. |
what
These changes fix the build for srcdir != builddir. At several points in the buildsystem relative (to the Makefile) paths were used. this does not work if a clean builddir is used, as the Makefile and generated headers reside in the builddir. auttools provide the variables
$(top_srcdir)and$(top_builddir)to refer to the srcdir and builddir respectivelyIf libxml2 is installed in a non-default location linking to libxml2 fails due to a missing LIBXML2_LDFLAGS
autotools don't support wildcards (see link to documentation below).
Note: Because these fixes use a GNU make extension, the build for non-GNU make is broken. If non-GNU make is supported by modsecurity, most likely the files need to be added explicitly. automake warns about this portability, thats why Werror was removed from automake options
Note2: I only fixed my configuration, there might be other optional parts of modsecurity, that make the same assumptions, which I did not touch.
why
references