-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Set default 'forwarded for' headers for reverse proxy #17868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5d9be0
to
4431fce
Compare
looks good to me 👍 |
Will test tomorrow. |
@LukasReschke How did your test go? 🙈 |
@LukasReschke ping |
Sorry. Simply forgot to feedback here. Works as advertised. Needs rebased though 😄 👍 |
4431fce
to
4970a0c
Compare
rebased ... |
@DeepDiver1975 Thanks 😄 |
|
4970a0c
to
2579999
Compare
A new inspection was created. |
DeepDiver1975
added a commit
that referenced
this pull request
Aug 11, 2015
Set default 'forwarded for' headers for reverse proxy
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vast majority of use cases of reverse proxy functionality will be with the 'X-Forwarded-For' HTTP header, so this PR sets that as the default. It will continue to be restricted by
trusted_proxies
, so there is no additional security impact.Also adds a basic setup check to highlight any glaring issues an admin might have. It can be extended later if necessary.
Requires owncloud-archive/documentation#1361 for doc link. Go review it 😄
Spoke to @LukasReschke about security, he said it's OK as long as it is documented properly ^^