Automatic music collection changes detection does not work in shared folders #706
Comments
|
Thanks for the report. This is something which is supposed to work, but maybe it has broken on some update. Or alternatively, something in your environment differs from my test environment. Anyway, I have to test this when I have time. |
|
Got this issue too, using NC 16.0.1 and Music 0.9.5 |
|
My memory didn't serve me quite right on my initial answer. This has probably never worked quite right. What does work, is when user A shares a file/folder with user B, and then the user A deletes one of the shared files. In that case, the file is removed automatically also from the library of B. If user A uploads new files to a shared folder, then the user B is prompted to scan them the next time she opens the Music app and I think this is adequate. But if user A modifies one of the shared files, then the change is never propagated to B's library, and this kind of sucks. Technically, it's somewhat problematic to update the B's library immediately on the file modification. Also, it could potentially create a performance issue since one file could be shared with a large number of users, and each user's library would need to be updated separately. The best solution could be to somehow mark the changed file as "dirty" in the B's library, and then rescan the dirty files when B next time opens the app. |
|
In my case: User A shares a folder full of music User B Music app does not see the new music that he uploaded to the share from User A |
|
@megamaced I tested your scenario on Nextcloud 16.0.3 and Music 0.10.0 but could not reproduce the issue. User B saw the newly uploaded OGG file immediately upon opening the Music app. User A, on the other hand, was prompted about new files and saw the uploaded file after clicking to scan the files. Is this something which happens systematically on your system. Does nextcloud.log show any errors after running these steps? |
|
@paulijar discovered it was my error, ignore me |
|
Hello, |
|
@sebastienserre If you wish, you can also limit the rescan to some specific folder by giving the option |
|
@slehoun |
- If the user's library contains any files potentially needing rescanning, this is now prompted to the user upon app loading, similarly as any new files to scan - The rescanning of modified files, both with the new prompt and using `occ music:scan --rescan-modified`, can now also remove files from the library if the modified file turns out to be within an excluded folder - When moving folder within the music library, and that folder contains more than 15 audio files, those files are now marked as "dirty" to trigger the mechanism described above. Previously, up to 30 files were rescanned immediately and over 30 files were removed from the library, which was sub-optimal. - This completes the fix for #1173 which was started with the commit 9c43c9c. This also provides a partial fix for the old issue #706.
|
This old issue is now mostly fixed in new Music v2.1.0. There, if another user "A" modifies a file shared with user "B", then "B" will be prompted to rescan the file the next time the Music app is loaded. There is a small residual issue, though: If the user "A" doesn't modify the file but moves it to another sub-folder within the shared folder, then the rescan is not prompted. If the moved file doesn't have the metadata tags set, then the folder names will be used as album and/or artist names but the change in these is now not reflected in "B"'s library. However, I have decided to ignore this for time being. |
When I change or modify music files, these changes propagate to my music library automatically. However this does not work for other users that I shared music with (i.e. the changes are only automatically applied to owners' library only). When I change music files, other users have to manually rebuild their music library.
Steps to reproduce
-User A uploads folder with music to his cloud.
-User A then shares this folder with user B.
-User A changes content of this folder. (User A's music library is updated automatically.)
Expected behavior
User B's music library is updated automatically.
Actual behavior
User B's music library needs manual rescan.
Server configuration
Operating system: CentOS Linux release 7.6.1810 (Core)
Web server: Apache 2.4.34
Database: MariaDB 5.5.60
PHP version: 7.2.10
Nextcloud version: 16.0.1
Updated from an older Nextcloud or fresh install: fresh install
List of activated apps:
Collabora Online 3.3.8
Accessibility 1.2.0
Activity 2.9.1
Brute-force settings 1.3.0
Calendar 1.7.0
Carnet 0.16.2
Collaborative tags 1.6.0
Comments 1.6.0
Deleted files 1.6.0
Federation 1.6.0
File sharing 1.8.0
First run wizard 2.5.0
Full text search 1.3.4
Full text search - Elasticsearch Platform 1.3.2
Full text search - Files 1.3.2
Gallery 18.3.0
Log Reader 2.1.0
Monitoring 1.6.0
Music 0.9.5
Nextcloud announcements 1.5.0
Notifications 2.4.1
Password policy 1.6.0
PDF viewer 1.5.0
Privacy 1.0.0
Recommendations 0.4.0
Right click 0.13.0
Share by mail 1.6.0
Support 1.0.0
Talk 6.0.2
Text editor 2.8.0
Theming 1.7.0
Update notification 1.6.0
Usage survey 1.4.0
Versions 1.9.0
Video player 1.5.0
Viewer 1.0.0
The content of config/config.php:
Are you using external storage, if yes which one: local/smb/sftp/...
no
Are you using encryption: yes/no
yes
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
no
Client configuration
Browser: Firefox 60.7.0esr, Chromium 73.0.3683.75
Operating system: Debian 9.9
Logs
Web server error log
Nextcloud log
The text was updated successfully, but these errors were encountered: