Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enabled playback speed context menu via right click #1006

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

Root-Core
Copy link
Contributor

On the PC it just feels weird to long press something with the mouse, therefore I want to allow calling the context menu via right click.

I also replaced getElementById() with an event on the button element itself. Feel free to revert this change, if it was deliberate.

Unified coding style / removed getElementById
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@paulijar
Copy link
Collaborator

Thanks, seems to work well. I was just thinking about adding this right-click option after reading your issue #1004.

I also replaced getElementById() with an event on the button element itself. Feel free to revert this change, if it was deliberate.

I actually didn't know of the ngOn directive and that you may use it to bind any custom events within the HTML template. But this makes the event binding more consistent, so I like it.

@paulijar paulijar merged commit be5084b into owncloud:master Aug 23, 2022
@paulijar
Copy link
Collaborator

This PR has now been released in Music v1.7.0.

@T0mWz
Copy link

T0mWz commented Dec 5, 2022

Where should this menu be visible? 🙈

@T0mWz
Copy link

T0mWz commented Dec 5, 2022

Where should this menu be visible? 🙈

Woow, found it finally. It's behind the play button, that is well hidden. Maybe an idea to add it as a separate button, like 'Playback speed', which opens this option?

@Root-Core Root-Core deleted the speed-rightclick branch February 27, 2023 23:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants