Support OGG using SoundManager2 #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurora.js, and choose between them according to file type. Currently, playback for FLAC works, soundmanager2 has not been connected to the wrapper.
| return AV.Player; | ||
| //return AV.Player; | ||
| return new PlayerWrapper(); | ||
| //return PlayerWrapper; |
There was a problem hiding this comment.
Can you drop these comments here?
|
Beside my comments this looks really awesome :) Thanks for the contribution :) |
|
A new inspection was created. |
|
@MorrisJobke Do you want to merge this PR first or you want to wait after #419 ? |
MorrisJobke
added a commit
that referenced
this pull request
Sep 3, 2015
Support OGG using SoundManager2
Closed
|
yay 🎆 🎆 |
MorrisJobke
added a commit
that referenced
this pull request
Oct 27, 2015
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new wrapper class
PlayerWrapperis created, which is used to call underlying Aurora.js or SoundManager2 depending on format.