-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Show radio stream title using php and rest api #992
Conversation
Thanks, much better now. There are still a few things which I would like to see improved, but I'll go into the details later. Please also check the things reported in the Scrutinizer inspection. |
…pi response from JSON to DATA
This is not really an issue details here: |
You could work around it by returning the metadata as JSON. Something like |
The inspection completed: 1 new issues, 6 updated code elements |
Do you consider this now to be ready for merging, or are you still planning to make any modifications? |
Yes it is ready to merge. |
This PR, along with a lot of further development built on top of it, has now been released in Music v1.6.0. |
Edit by @paulijar: This PR implements radio stream title fetching for icecast/shoutcast -type radio channels. Related to #829.