Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show radio stream title using php and rest api #992

Merged
merged 9 commits into from
Jun 29, 2022

Conversation

medismail
Copy link
Contributor

@medismail medismail commented Jun 26, 2022

Edit by @paulijar: This PR implements radio stream title fetching for icecast/shoutcast -type radio channels. Related to #829.

@paulijar
Copy link
Collaborator

Thanks, much better now. There are still a few things which I would like to see improved, but I'll go into the details later. Please also check the things reported in the Scrutinizer inspection.

@medismail
Copy link
Contributor Author

The inspection completed: 2 new issues, 7 updated code elements

This is not really an issue details here:
nextcloud/server@1e111b2
It already solved in nextcloud, maybe it should be reported to owncloud.

@paulijar
Copy link
Collaborator

This is not really an issue

You could work around it by returning the metadata as JSON. Something like return new JSONResponse(['title' => $response]);. And that would also be more in line with how our REST API works in general.

appinfo/routes.php Outdated Show resolved Hide resolved
js/app/controllers/playercontroller.js Outdated Show resolved Hide resolved
js/app/controllers/playercontroller.js Outdated Show resolved Hide resolved
lib/Utility/RadioMetadata.php Outdated Show resolved Hide resolved
lib/Utility/RadioMetadata.php Outdated Show resolved Hide resolved
@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues, 6 updated code elements

@paulijar
Copy link
Collaborator

Do you consider this now to be ready for merging, or are you still planning to make any modifications?

@medismail
Copy link
Contributor Author

Yes it is ready to merge.

@paulijar paulijar merged commit 6159701 into owncloud:master Jun 29, 2022
@paulijar
Copy link
Collaborator

This PR, along with a lot of further development built on top of it, has now been released in Music v1.6.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants