Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Only try to getParams() for get requests - otherwise it tries to parse the request body #100

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Nov 27, 2017

No description provided.

@DeepDiver1975 DeepDiver1975 self-assigned this Nov 27, 2017
@DeepDiver1975 DeepDiver1975 added this to the development milestone Nov 27, 2017
@DeepDiver1975 DeepDiver1975 changed the title Use proper urlParameter collection - getParams() tries to parse the r… Only try to getParams() for get requests - otherwise it tries to parse the request body Nov 27, 2017
@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #100 into master will decrease coverage by 0.24%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #100      +/-   ##
===========================================
- Coverage     81.65%   81.4%   -0.25%     
- Complexity      184     185       +1     
===========================================
  Files            20      20              
  Lines           654     656       +2     
===========================================
  Hits            534     534              
- Misses          120     122       +2
Impacted Files Coverage Δ Complexity Δ
lib/AppInfo/Application.php 21.56% <0%> (-0.89%) 13 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0826a0...3ce540b. Read the comment docs.

@SamuAlfageme
Copy link
Contributor

SamuAlfageme commented Nov 27, 2017

@DeepDiver1975 public upload (w/ and wo/ listing permissions) working as a charm. 👍

I'm getting a log entry on the apps list about oauth2 not sure if related to the branch not being signed:

"url":"/settings/apps/list?category=enabled",
"message":"file_get_contents(/var/www/owncloud/apps/oauth2/appinfo/signature.json): failed to open stream: No such file or directory at /var/www/owncloud/lib/private/IntegrityCheck/Helpers/FileAccessHelper.php#39

Smoke tested the rest of the OAuth2 auth. flow and sync functionality in core and no news; everything working just fine.

@DeepDiver1975
Copy link
Member Author

"message":"file_get_contents(/var/www/owncloud/apps/oauth2/appinfo/signature.json): failed to open stream: No such file or directory at /var/www/owncloud/lib/private/IntegrityCheck/Helpers/FileAccessHelper.php#39

this is because the app is not signed -> ignore

@DeepDiver1975
Copy link
Member Author

did you reverify the fully oauth flow?
Just to make sure we dont break anything else - THX

@SamuAlfageme
Copy link
Contributor

@DeepDiver1975 yup, edited the comment to explicitly say so. Everything looking shiny.

@DeepDiver1975 DeepDiver1975 merged commit b09e2b0 into master Nov 27, 2017
@DeepDiver1975 DeepDiver1975 deleted the fix-public-upload branch November 27, 2017 14:19
@patrickjahns patrickjahns mentioned this pull request Nov 27, 2017
13 tasks
SamuAlfageme added a commit to owncloud/QA that referenced this pull request Nov 28, 2017
@dpakach dpakach mentioned this pull request Apr 30, 2019
@jnweiger jnweiger mentioned this pull request Apr 22, 2020
@jnweiger jnweiger mentioned this pull request Nov 9, 2021
@jnweiger jnweiger mentioned this pull request Mar 11, 2022
@jnweiger jnweiger mentioned this pull request Aug 30, 2023
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants