Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

in case the token is no longer valid we properly need to … #118

Merged
merged 2 commits into from
Feb 23, 2018

Conversation

DeepDiver1975
Copy link
Member

…handle the exception

fixes #117

@DeepDiver1975 DeepDiver1975 added this to the development milestone Feb 23, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this Feb 23, 2018
@jesmrec
Copy link

jesmrec commented Feb 23, 2018

👍works from my side.

Checked in Android & iOS with different kinds of request to trigger the expiration (PROPFIND, PUT, GET, MKCOL..)

@DeepDiver1975
Copy link
Member Author

THX @jesmrec - I'll get travis back in shape and then we merge.

@codecov
Copy link

codecov bot commented Feb 23, 2018

Codecov Report

Merging #118 into master will decrease coverage by 0.08%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
- Coverage     82.09%   82.01%   -0.09%     
- Complexity      194      199       +5     
============================================
  Files            21       21              
  Lines           687      695       +8     
============================================
+ Hits            564      570       +6     
- Misses          123      125       +2
Impacted Files Coverage Δ Complexity Δ
lib/AuthModule.php 91.66% <0%> (-8.34%) 8 <0> (+1)
lib/Sabre/OAuth2.php 96.96% <100%> (+0.3%) 9 <0> (+1) ⬆️
lib/AppInfo/Application.php 25.92% <0%> (+4.35%) 16% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be6362...79d24db. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit a2d007e into master Feb 23, 2018
@DeepDiver1975 DeepDiver1975 deleted the bugfix/117 branch February 23, 2018 15:18
@DeepDiver1975 DeepDiver1975 mentioned this pull request Feb 23, 2018
17 tasks
@patrickjahns patrickjahns modified the milestones: development, QA Feb 23, 2018
@patrickjahns
Copy link
Contributor

Moved to QA -> see #116 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception "Invalid Token" when token expires
3 participants