fix session password #129
Merged
fix session password #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=========================================
Coverage 82.12% 82.12%
Complexity 199 199
=========================================
Files 21 21
Lines 705 705
=========================================
Hits 579 579
Misses 126 126
Continue to review full report at Codecov.
|
DeepDiver1975
approved these changes
Apr 19, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while working on kerberos. Password should be
nullinstead of''IIUC that null triggers\OC\Authentication\Exceptions\PasswordlessTokenExceptionto make sessions without a password work properly. No idea if ther is magic in core that converts '' to null ... oracle certainly has that magic ... so no idea how this affects the overall auth with oauth2.