fix: browser field resolving relative to path to itself (#34)

oxc-project · Dec 17, 2023 · c4432a5 · c4432a5
1 parent b3d8f7c
commit c4432a5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/fixtures/enhanced_resolve/test/fixtures/browser-module/package.json b/fixtures/enhanced_resolve/test/fixtures/browser-module/package.json
@@ -6,6 +6,7 @@
     "module-b": "module-c",
     "module-c": "module-c",
     "./toString": "./lib/toString.js",
+    "./lib/main.js": "./lib/main.js",
     ".": false
   },
   "innerBrowser1": {

diff --git a/src/lib.rs b/src/lib.rs
@@ -788,6 +788,12 @@ impl<Fs: FileSystem + Default> ResolverGeneric<Fs> {
         let Some(new_specifier) = package_json.resolve_browser_field(path, specifier)? else {
             return Ok(None);
         };
+        // Finish when resolving to self `{"./a.js": "./a.js"}`
+        if let Some(new_specifier) = new_specifier.strip_prefix("./") {
+            if path.ends_with(Path::new(new_specifier)) {
+                return Ok(Some(cached_path.clone()));
+            }
+        }
         if specifier.is_some_and(|s| s == new_specifier) {
             return Ok(None);
         }

diff --git a/src/tests/browser_field.rs b/src/tests/browser_field.rs
@@ -61,6 +61,7 @@ fn replace_file() {
         ("should check only alias field properties", f.clone(), "./toString", f.join("lib/toString.js")),
         // not part of enhanced-resolve
         ("recursion", f.clone(), "module-c", f.join("node_modules/module-c.js")),
+        ("resolve self", f.clone(), "./lib/main.js", f.join("lib/main.js")),
     ];
 
     for (comment, path, request, expected) in data {