Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: bring back the symlink optimization #298

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Nov 8, 2024

Compare with the main branch on macOS:

❯ cargo bench --bench resolver -- --baseline main
   Compiling oxc_resolver v2.0.0 (/Users/brooklyn/workspace/github/oxc-resolver)
    Finished `bench` profile [optimized] target(s) in 9.35s
     Running benches/resolver.rs (target/release/deps/resolver-f9459fb995da5b5c)
resolver/single-thread  time:   [64.969 µs 65.152 µs 65.356 µs]
                        change: [−1.7486% +0.8367% +3.3798%] (p = 0.56 > 0.05)
                        No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
  3 (3.00%) high mild
  5 (5.00%) high severe
resolver/multi-thread   time:   [59.400 µs 60.303 µs 61.292 µs]
                        change: [−3.5542% −1.0722% +1.5586%] (p = 0.43 > 0.05)
                        No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe
resolver/resolve from symlinks
                        time:   [191.17 ms 193.86 ms 196.44 ms]
                        change: [−65.691% −65.058% −64.412%] (p = 0.00 < 0.05)
                        Performance has improved.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.00%. Comparing base (edc503c) to head (ce4f699).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   97.05%   97.00%   -0.06%     
==========================================
  Files          11       11              
  Lines        2378     2369       -9     
==========================================
- Hits         2308     2298      -10     
- Misses         70       71       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #298 will not alter performance

Comparing 11-08-perf_bring_back_the_symlink_optimization (ce4f699) with main (edc503c)

Summary

✅ 3 untouched benchmarks

@Brooooooklyn Brooooooklyn requested a review from Boshen November 8, 2024 06:35
@Boshen Boshen merged commit 96825a3 into main Nov 8, 2024
22 checks passed
@Boshen Boshen deleted the 11-08-perf_bring_back_the_symlink_optimization branch November 8, 2024 06:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants